Improve glass pane rendering

[Majora320]

Currently the rendering for the clear glass and stained glass panes is somewhat broken, displaying unwanted vertical lines when viewed from certain angles. Stained glass rendering & connectivity is also not optimal. This commit implements custom glass rendering based off of Vanilla that should be an improvement and allow for artifact-free clear glass panes in builds.

Fixes #267

Before:

After:

[Majora320]

Fixes #267

[DarkShadow44]

That doesn't look correct here:

[DarkShadow44]

The panes don't really look good in an inventory, any specific reason you removed the 3d look?

[Luca-Guettinger]

3 nits. (I only looked at the code, not ingame for now)

[Majora320]

The panes don't really look good in an inventory, any specific reason you removed the 3d look?

I did that to more closely match the look to that of vanilla glass, should it stay like that? I have no preference either way.

[Majora320]

That doesn't look correct here:

I'm not sure if getting a perfect result in these edge cases is feasible unfortunately, I tried fixing the rendering for the top/bottom face in these, but the edges are still broken and it still looks kinda bad. Fixing this would require a lot of additional complexity + more textures...

[DarkShadow44]

The panes don't really look good in an inventory, any specific reason you removed the 3d look?

I did that to more closely match the look to that of vanilla glass, should it stay like that? I have no preference either way.

I certainly liked the old look a lot better

[DarkShadow44]

Can you please fix the block breaking animation? In survival it looks very weird trying to break the panes

[DarkShadow44]

I'm not sure if getting a perfect result in these edge cases is feasible unfortunately, I tried fixing the rendering for the top/bottom face in these, but the edges are still broken and it still looks kinda bad. Fixing this would require a lot of additional complexity + more textures...

There has to be a simpler way... Can't we split the panes into middle and side parts and render each accordingly? If you want I could try and take a stab at it, but it would take some time until I get to it.

[Luca-Guettinger]

1 potential regression (torch placement on stained glass), 2 nits.

[DarkShadow44]

There's still the two issues I mentioned:

• The edge cases with connectivity
• The survival block breaking being glitchy

[DarkShadow44]

@Majora320
Ah right, totally forgot about the block breaking animation, thanks for the fix! After testing so long with the flat 2D panes they kinda grew on me, so I retract my earlier preference for the old 3D look. But since you already went out of your way to restore 3D inventory rendering, I'll leave the final choice up to you.

What do you say to my changes regarding pane rendering? Both the look and the code logic.

[Luca-Guettinger]

1 minor bug (inventory bottom icon for stained panes), 1 nit.

[Majora320]

After testing so long with the flat 2D panes they kinda grew on me, so I retract my earlier preference for the old 3D look. But since you already went out of your way to restore 3D inventory rendering, I'll leave the final choice up to you.

I think 3D isn't a bad idea to differentiate them from vanilla panes, otherwise they look very similar.

What do you say to my changes regarding pane rendering? Both the look and the code logic.

Looks good to me, thanks for doing the annoying work of handling all the edge cases :) the rendering is quite smooth now

[Luca-Guettinger]

works

[DarkShadow44]

Great, thanks for your work, a welcome improvement!