allow applying modifiers multiple times#290
Closed
sawyergt wants to merge 8 commits into
Closed
Conversation
couldn't figure out how to modify `addToolTip` in a reasonable way
previous approach had some issues in that addons could override `ItemModifier`'s methods, which meant that it would only really work with tinker's modifiers any incompatible mod would apply the modifier once and then void all items in the tool slot this, while hacky, should retain compatibility with every addon P.S: i also modified `ToolStationContainer`/`ToolForgeContainer`, but they dont seem to be used, at least not in my testing
Author
|
with the current changes, it works for modifiers such as lapis, redstone, etc. and tool repairs ideas are welcome |
Member
|
Hi! |
Author
|
closing in favor of #294 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current behaviour of the Tool Station/Tool Forge is to consume and apply only one modifier material per slot to a tool when craft. This PR changes it to allow the modifier to be applied multiple times in the same craft.
preview.webm