render traveller accessories from Baubles slots when Tinker tab is disabled#291
Open
Eldrinn-Elantey wants to merge 1 commit into
Open
render traveller accessories from Baubles slots when Tinker tab is disabled#291Eldrinn-Elantey wants to merge 1 commit into
Eldrinn-Elantey wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the Tinker inventory tab is disabled (default after #279), accessories go into Baubles-Expanded slots but weren't rendered on the player because
renderArmorExtrasstill read fromarmorExtended.inventory. Fixed by reading from Baubles inventory when the tab is disabled, keeping the original path when it's enabled.