Skip to content

🎨 Palette: Add delete confirmation and improve button accessibility#20

Open
Gamepulse wants to merge 1 commit into
Devfrom
palette/ux-accessibility-improvements-14253415800839702215
Open

🎨 Palette: Add delete confirmation and improve button accessibility#20
Gamepulse wants to merge 1 commit into
Devfrom
palette/ux-accessibility-improvements-14253415800839702215

Conversation

@Gamepulse
Copy link
Copy Markdown
Owner

This PR implements micro-UX and accessibility improvements across the library view:

  1. Destructive Action Safety: Added a confirmation dialog to the "Delete Game" action in GameDetail.tsx. Users will now be prompted to confirm before a game is removed from their library.
  2. Accessibility (ARIA):
    • Added aria-label and aria-hidden to the "Quick assign platform" buttons (🎮) in GameCard.tsx (all view modes).
    • Added aria-label and aria-hidden to the "Clear executable path" button (✕) in GameDetail.tsx.
    • Added aria-label and aria-hidden to the favorite toggle button in GameDetailHeader.tsx.
  3. Build Fix: Removed an unused hasIgdbId state variable in GameScreenshotsCarousel.tsx that caused tsc to fail during the production build.

These changes ensure the application is more accessible to screen reader users and safer for all users when performing permanent actions.


PR created automatically by Jules for task 14253415800839702215 started by @Gamepulse

- Added a confirmation dialog to the "Delete Game" action in GameDetail.tsx to prevent accidental data loss.
- Improved accessibility of icon-only buttons in GameCard.tsx, GameDetail.tsx, and GameDetailHeader.tsx by adding aria-labels and aria-hidden on decorative emojis.
- Fixed an unused state variable in GameScreenshotsCarousel.tsx that was blocking the production build.

Co-authored-by: Gamepulse <8333979+Gamepulse@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant