Skip to content

🎨 Palette: Improve GameCard accessibility#24

Open
Gamepulse wants to merge 1 commit into
Devfrom
palette-gamecard-accessibility-8158581704525922385
Open

🎨 Palette: Improve GameCard accessibility#24
Gamepulse wants to merge 1 commit into
Devfrom
palette-gamecard-accessibility-8158581704525922385

Conversation

@Gamepulse
Copy link
Copy Markdown
Owner

I have improved the accessibility of the GameCard component by converting non-semantic interactive elements into proper HTML buttons.

💡 What:

  • Replaced span role="button" with <button type="button"> for tags, metadata, and status badges.
  • Added descriptive aria-label attributes to these buttons.
  • Implemented focus-visible:ring-2 styles to ensure clear visual feedback for keyboard users.
  • Cleaned up an unused variable in GameScreenshotsCarousel.tsx that was causing build failures.

🎯 Why:
This change makes the game library much more navigable for users who rely on keyboards or screen readers, ensuring that all interactive elements are correctly identified and reachable.

Accessibility:

  • Native keyboard support (Enter/Space) via semantic buttons.
  • Clearer focus indicators.
  • Meaningful ARIA labels for icon-only and badge elements.

PR created automatically by Jules for task 8158581704525922385 started by @Gamepulse

- Convert span role="button" to semantic <button> elements in GameCard.tsx
- Add aria-labels and focus-visible styles to GameCard interactive elements
- Fix unused state variable in GameScreenshotsCarousel.tsx to resolve build error
- Add unit tests for GameCard accessibility
- Update Palette journal with UX learnings

Co-authored-by: Gamepulse <8333979+Gamepulse@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant