🎨 Palette: Improve GameCard accessibility and keyboard navigation#29
🎨 Palette: Improve GameCard accessibility and keyboard navigation#29Gamepulse wants to merge 1 commit into
Conversation
- Added keyboard navigation support (Enter/Space) to GameCard - Converted interactive spans to semantic buttons for tags and status badges - Added ARIA labels and focus-visible indicators to all interactive elements - Fixed card click regression by ensuring child interactions don't block parent container when focused - Removed unused 'hasIgdbId' in GameScreenshotsCarousel to fix build error Co-authored-by: Gamepulse <8333979+Gamepulse@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
This PR improves the accessibility and micro-UX of the
GameCardcomponent.💡 What
role="button",tabIndex={0}, andaria-labelto theGameCardcontainer.onKeyDownto allow navigating to game details using the keyboard (Enter/Space).<span>tags for genres, modes, and status badges into semantic<button type="button">elements.focus-visible:ring-2focus indicators for better visibility during keyboard navigation.role="button"would block card clicks by updating thetarget.closestlogic.GameScreenshotsCarousel.tsxthat was causing a build failure.🎯 Why
♿ Accessibility
PR created automatically by Jules for task 2343183734902612041 started by @Gamepulse