Skip to content

🎨 Palette: Accessibility and UX improvements for Game Library#34

Open
Gamepulse wants to merge 1 commit into
Devfrom
palette/ux-a11y-improvements-2157829674852402055
Open

🎨 Palette: Accessibility and UX improvements for Game Library#34
Gamepulse wants to merge 1 commit into
Devfrom
palette/ux-a11y-improvements-2157829674852402055

Conversation

@Gamepulse
Copy link
Copy Markdown
Owner

This PR introduces several micro-UX and accessibility improvements:

  1. Safety for Destructive Actions: Added a window.confirm dialog when deleting a game in GameDetail.tsx, using the existing confirmDelete translation key.
  2. Accessibility for Icon-only Buttons:
    • Added aria-label to the "Clear executable path" button in GameDetail.tsx.
    • Added aria-label to the "Quick assign platform" buttons in GameCard.tsx.
    • Added aria-label to the favorite toggle button in GameDetailHeader.tsx.
    • Wrapped decorative emojis in <span aria-hidden="true"> to ensure clean screen reader output.
  3. Build Fix: Removed the unused hasIgdbId state variable in GameScreenshotsCarousel.tsx to satisfy strict TypeScript checks during production build.

Verified with pnpm test, pnpm build, and visual inspection via Playwright.


PR created automatically by Jules for task 2157829674852402055 started by @Gamepulse

- Added a confirmation dialog before deleting a game to prevent accidental data loss.
- Improved accessibility for icon-only buttons (Quick assign, Clear path, Favorites) by adding `aria-label` and `aria-hidden="true"` for emojis.
- Fixed a build error in `GameScreenshotsCarousel.tsx` by removing an unused state variable.

Co-authored-by: Gamepulse <8333979+Gamepulse@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant