Skip to content

🎨 Palette: Accessibility and UX improvements for Game Detail#36

Open
Gamepulse wants to merge 1 commit into
Devfrom
palette-ux-improvements-gamedetail-7200428472585812498
Open

🎨 Palette: Accessibility and UX improvements for Game Detail#36
Gamepulse wants to merge 1 commit into
Devfrom
palette-ux-improvements-gamedetail-7200428472585812498

Conversation

@Gamepulse
Copy link
Copy Markdown
Owner

This PR implements several micro-UX and accessibility improvements in the GameDetailHeader component to make the interface more intuitive and inclusive.

💡 What:

  1. Accessibility: Added aria-hidden="true" to the decorative "PPGM" branding mask on game covers.
  2. Accessibility: Added aria-label to the favorite toggle button for better screen reader support.
  3. UX & Accessibility: Replaced the rating display with a proper <label> associated with the range input via htmlFor/id.
  4. UX: Added a "Clear All" button (✕) next to the personal rating, allowing users to reset their rating to an unset state.
  5. Build: Removed an unused hasIgdbId state in GameScreenshotsCarousel.tsx that was causing tsc build failures.

🎯 Why:

  • Decorative text overlays can be confusing for screen reader users if not hidden.
  • Icon-only buttons need explicit labels for accessibility.
  • Standard HTML range inputs don't have a built-in "null" state, so a clear button is required to allow users to remove a rating.
  • Fixing the build error ensures the project remains maintainable and deployable.

♿ Accessibility:

  • Improved form control labeling.
  • Enhanced screen reader context for interactive elements.
  • Reduced noise by hiding decorative elements.

PR created automatically by Jules for task 7200428472585812498 started by @Gamepulse

- Add aria-hidden="true" to branding overlay
- Add aria-label to favorite toggle button
- Add proper label/id association for personal rating input
- Add "Clear All" button to unset personal rating
- Fix unused variable in GameScreenshotsCarousel to allow build to pass

Co-authored-by: Gamepulse <8333979+Gamepulse@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant