Skip to content

🎨 Palette: Accessible Favorite toggle and Clear Rating button#37

Open
Gamepulse wants to merge 1 commit into
Devfrom
palette-ux-improvements-7366151441224788551
Open

🎨 Palette: Accessible Favorite toggle and Clear Rating button#37
Gamepulse wants to merge 1 commit into
Devfrom
palette-ux-improvements-7366151441224788551

Conversation

@Gamepulse
Copy link
Copy Markdown
Owner

This PR introduces micro-UX and accessibility improvements to the game detail view:

  • ♿ Accessibility: Icon-only buttons (Favorite toggle) now have proper `aria-label` attributes. Decorative star icons and text masks are now hidden from screen readers to prevent redundant or confusing announcements.
  • ✨ UX Enhancement: Added a "Clear Rating" button next to the personal rating. Since the standard range input doesn't allow unsetting a value, this button provides an intuitive way for users to remove their personal rating.
  • 🌐 Localization: Added the new `clearRating` string to the i18n system for both English and French.
  • 🛠️ Fixes: Removed an unused variable in `GameScreenshotsCarousel.tsx` that was causing production build failures.

Verified with `pnpm test`, `pnpm build`, and a Playwright-based visual check.


PR created automatically by Jules for task 7366151441224788551 started by @Gamepulse

- Added \`aria-label\` and \`aria-hidden\` to the Favorite toggle button for better screen reader support.
- Marked decorative "PPGM" text mask as \`aria-hidden="true"\`.
- Implemented a "Clear Rating" button to allow users to reset personal ratings to null.
- Added \`clearRating\` translation keys for English and French.
- Fixed a pre-existing TypeScript error in \`GameScreenshotsCarousel.tsx\` to ensure successful build.

Co-authored-by: Gamepulse <8333979+Gamepulse@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant