🎨 Palette: Add "Clear Rating" button to Game Detail#38
Conversation
- Added 'Clear Rating' button to GameDetailHeader to allow unsetting personal ratings. - Added localized strings for 'Clear Rating' in English and French. - Ensured the button is accessible with ARIA labels and focus states. - Fixed a TypeScript error in GameScreenshotsCarousel.tsx (unused 'hasIgdbId' state) that was blocking the production build. - Added a UX learning entry to .Jules/palette.md regarding range inputs and null states. Co-authored-by: Gamepulse <8333979+Gamepulse@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
This PR implements a micro-UX improvement in the Game Detail view.
💡 What: Added a "Clear Rating" button next to the personal rating range input.
🎯 Why: Users previously had no way to unset a rating once it was moved from its initial state. Since the range input always represents a number, a separate action was needed to restore the 'null' (unrated) state.
♿ Accessibility: The new button includes an
aria-labelandtitle, uses semantic<button type="button">, and features clear focus indicators. The '✕' icon is hidden from screen readers to avoid redundancy.🔧 Maintenance: Fixed a pre-existing TypeScript error in
GameScreenshotsCarousel.tsxwherehasIgdbIdwas declared but never used, which was causingpnpm buildto fail.Verified with
pnpm test,pnpm build, and visual verification using Playwright.PR created automatically by Jules for task 12553911808481257865 started by @Gamepulse