🎨 Palette: UX and Accessibility enhancements for Game Detail Header#39
🎨 Palette: UX and Accessibility enhancements for Game Detail Header#39Gamepulse wants to merge 1 commit into
Conversation
…Header
This commit introduces several micro-UX and accessibility improvements to the `GameDetailHeader` component:
1. **Clear Rating Feature**: Added a "Clear Rating" button next to the personal rating slider, allowing users to unset their rating.
2. **Semantic Elements**: Converted the folder path from a non-semantic `<p>` tag to a proper `<button type="button">` for keyboard accessibility and native interaction.
3. **ARIA and Screen Reader Support**:
- Added `aria-label` and `title` to icon-only buttons (Favorite toggle, Clear Rating).
- Wrapped decorative icons and emojis in `<span aria-hidden="true">` to ensure clean screen reader output.
- Associated the personal rating slider with its label using `id` and `htmlFor`.
4. **Internationalization**: Added `clearRating` translation keys for English and French, and fixed a typo in the English `platforms` translation.
5. **Cleanup**: Removed an unused `hasIgdbId` state in `GameScreenshotsCarousel.tsx` to fix a build error.
These changes improve the overall accessibility and intuitiveness of the game details interface.
Co-authored-by: Gamepulse <8333979+Gamepulse@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
I've implemented a set of micro-UX improvements in the
GameDetailHeadercomponent to enhance accessibility and usability.Key changes include:
<button>so it's keyboard-accessible.aria-labelto the favorite star button.aria-hiddento avoid screen reader clutter.GameScreenshotsCarousel.tsxthat was causing build failures.All changes have been verified with a production build (
pnpm build), unit tests (pnpm test), and visual inspection via Playwright.PR created automatically by Jules for task 6264644426523944563 started by @Gamepulse