Skip to content

🎨 Palette: Clear Rating UX Improvement & Localization Fix#40

Open
Gamepulse wants to merge 1 commit into
Devfrom
palette-ux-improvements-11079253541627504770
Open

🎨 Palette: Clear Rating UX Improvement & Localization Fix#40
Gamepulse wants to merge 1 commit into
Devfrom
palette-ux-improvements-11079253541627504770

Conversation

@Gamepulse
Copy link
Copy Markdown
Owner

This PR implements a micro-UX improvement for the game detail view and fixes a localization typo.

💡 What:

  1. Clear Rating Button: Added a small ✕ button next to the personal rating value. This allows users to reset their rating to null, which was previously impossible once a rating was set because the range slider always has a value.
  2. Localization Fix: Corrected the English translation key for platforms, which was incorrectly set to the French word "Plateformes".
  3. Build Fix: Removed an unused state variable (hasIgdbId) in GameScreenshotsCarousel.tsx that was causing pnpm build to fail.

🎯 Why:

  • Native range inputs don't support a null state, leading to a poor user experience when someone wants to remove a rating.
  • Inconsistent localization (French in the English translation) reduces the professional feel of the app.
  • Fixing build errors ensures continuous integration remains green.

♿ Accessibility:

  • The new "Clear" button uses aria-label and title for screen readers and tooltips.
  • The ✕ icon is wrapped in <span aria-hidden="true"> to prevent screen readers from reading the literal character incorrectly.
  • Focus visible rings are applied to the new interactive element.

📸 Before/After:

[Verification screenshots and videos have been generated and reviewed during the verification step.]


PR created automatically by Jules for task 11079253541627504770 started by @Gamepulse

- Added an accessible "Clear Rating" button (✕) to the personal rating section in GameDetailHeader to allow unsetting ratings.
- Corrected the English translation for "Platforms" (was "Plateformes").
- Added localized strings for "Clear Rating" in English and French.
- Fixed a TypeScript error in GameScreenshotsCarousel causing build failures.
- Ensured proper accessibility with aria-labels and tooltips.

Co-authored-by: Gamepulse <8333979+Gamepulse@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant