Repository navigation
fix: guard against None in data_collection projected_temperature round() - #10
Merged
Merged
Conversation
Agent-Logs-Url: https://github.com/Gamso/smart_fan_controller/sessions/87b4ec4e-2fc0-4309-b6b8-ae03ea4b43b0 Co-authored-by: Gamso <13354981+Gamso@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR hardens the CSV data logger (DataCollector) to avoid runtime errors when projected_temperature (and related projected error) are present in the controller decision payload but set to None, which would previously raise during round().
Changes:
- Added a small
_coalesce()helper to substitute defaults when a value isNone. - Updated CSV row construction to coalesce
projected_temperatureandprojected_temperature_errorbefore rounding.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Agent-Logs-Url: https://github.com/Gamso/smart_fan_controller/sessions/87b4ec4e-2fc0-4309-b6b8-ae03ea4b43b0