rearrange middleware so CORS is applied to all responses#391
Merged
Conversation
WillEngler
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #389
Overview
This PR fixes and issue I found testing yesterday's changes in staging:
Our nice error messages aren't accessible due to missing CORS headers. I think this is due to the order we are applying the middlewares:
Before (broken):
Request → HeaderLogging → RequestID → ProcessTime → ErrorHandling → CORS → Routes
Errors are bypassing the CORS middleware, so making sure we wrap the response with CORS headers first should fix the issue.
After (fixed, hopefully):
Request → CORS → HeaderLogging → RequestID → ProcessTime → ErrorHandling → Routes
Testing
Tough to test locally since my local setup doesn't send cross-origin requests. We will need to get this into dev to see if it works.