Remove client-side filtering a facet calculations#473
Merged
Conversation
WillEngler
pushed a commit
to Garden-AI/garden-frontend-staging
that referenced
this pull request
Nov 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #474
This PR removes the client-side search filtering and facet calculation introduced in #469. Now we rely on the backend for all filtering and facet calculation.
This was causing some issues in the the pagination and counting logic. Turns when out applying client-side filtering we can't know which of the gardens on the next page will be filtered out until they get here which causes quite a few issues with correctly rendering counts and page indications.
Client-side filtering seemed like a good idea at the time -- turns out we need to do all of the filtering in one place to stay consistent. Seems obvious in hindsight. You live and learn.