fix(ci): measure citation reachability from HEAD, not the base branch#167
Merged
Conversation
Checking ancestry against origin/main rejected a legitimate pattern: a CHANGELOG entry citing an earlier commit of the same pull request. That commit is not an ancestor of the base branch until the PR merges, so the gate would have failed correct work. HEAD is the right target. For a pull request it is the merge commit, which is the state a reader clones after merge. A commit reachable from no ref at all is still caught - verified by pointing the check at an older ref, which produces 12 detections rather than passing vacuously. Signed-off-by: Gavin Borges <gavinmborges1104@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checking ancestry against origin/main rejected a legitimate pattern: a CHANGELOG entry citing an earlier commit of the same pull request. That commit is not an ancestor of the base branch until the PR merges, so the gate would have failed correct work.
HEAD is the right target. For a pull request it is the merge commit, which is the state a reader clones after merge. A commit reachable from no ref at all is still caught - verified by pointing the check at an older ref, which produces 12 detections rather than passing vacuously.
Summary
Type of Change
PR Checklist
Code Quality
ruff check .passes (no lint errors)mypy src/passes (0 new errors)pytestpasses (all tests green, no regressions)Biological Accuracy (required for any model, feature, or claims change)
docs/claims_register.mdupdated with any new public-facing claimsModel / Feature Changes (if applicable)
docs/feature_glossary.mdupdated if feature set changeddocs/model_cards/updated if model performance changedconfig.yamlfeature_modeandmodel_pathupdated if a new model is canonicaldocs/model_evaluation_summary.mdupdated with new AUC-PR resultData Changes (if applicable)
data/immunogenicity_dataset_v4_schema.jsondocs/data_registry.mdupdated with row counts, class balance, and provenanceantigen_processing_cache_pathupdated if new peptides introducedDocumentation
CHANGELOG.mdupdated (under[Unreleased])docs/limitations_statement_v1.mdupdated if a new limitation is introduceddocs/antigen_accessions.mdupdated if new viruses or accessions addedTesting Evidence
Before / After (for model changes)
Reviewer Notes