Add RC-KT analysis operators - #590
Merged
Merged
Conversation
Add optional RC-KT analysis dependencies
This was referenced Aug 26, 2026
# Conflicts: # README.md
skim0119
force-pushed
the
feat/rc-kt-operators
branch
from
August 26, 2026 16:26
cf621c9 to
386edb1
Compare
skim0119
force-pushed
the
feat/rc-kt-operators
branch
from
August 27, 2026 01:43
386edb1 to
451d632
Compare
skim0119
force-pushed
the
feat/rc-kt-operators
branch
from
August 27, 2026 01:48
451d632 to
2072af5
Compare
Collaborator
Author
|
Merge after checking unittests |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #590 +/- ##
==========================================
+ Coverage 86.17% 86.25% +0.08%
==========================================
Files 28 28
Lines 1157 1157
Branches 115 115
==========================================
+ Hits 997 998 +1
+ Misses 135 134 -1
Partials 25 25
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add reusable RC-KT analysis operators, numerical corrections required by the SI, grouped HDF5 imports, serializable result objects, deterministic seeds, algorithm-version cache fields, tests, and 0.5.0 migration notes.
Corrected existing implementations
n_spikes ** (4/5)by default), correct the Gaussian exponent, and use numerically stable bandwidth-ratio scaling.rho * exp(-rho * tau)kernel and exclude future spikes.These changes intentionally alter numerical results. Affected operators expose an
algorithm_versionin their cache identity and are documented as a MiV-OS 0.5.0 numerical migration.New operators and APIs
BayesianAdaptiveKernelSmootherBranchingRatioTTLPulseDecoderTTLPulseDecoderandFixedDurationTrializeras explicit serial nodesExponentialSpikeEncoderKernelRankSpectralRadiusRidgeReadoutwith stratified holdout, cross-validated ridge selection, balanced accuracy, and confusion matrixKnowledgeTransferInputBuilderKnowledgeTransferTrialSelectorandGPFALatentProjectorKnowledgeTransferImportSignalalso gains HDF5 group and container selection so alignedEphysandStimulusgroups can enter normal MiV graphs.Paired-input knowledge transfer
KnowledgeTransferInputBuilderverifies that expert and student recordings contain the same number of trials and the same stimulus-label sequence. The downstream modules remain explicit:The graph performs the following explicit sequence:
Every stage is independently runnable and cacheable. The expert-to-student edge is intentional: it is the serial dependency that freezes expert kernel parameters during the student fit.
KnowledgeTransferResultincludes paired latent features, labels, the expert readout, coordinate transform, transplanted weights, and refined weights. The lower-level pre-embedded latent-array API remains available.Callback and persistence review note
plot_*diagnostics.DirectedConnectivitymatrix and histogram callbacks remain active, and the formerly disabled node-wise callback now runs when an MEA geometry is supplied.KnowledgeTransferInputBuilderand trial selectors) intentionally have no plots.Dependency
Built on #588. The direct
miv-state-spacedependency temporarily tracksfeat/rc-kt-hgpfa; package publication will be handled separately.Validation
Focused operator tests pass, including a synthetic fully modular pipeline test that verifies the student GPFA receives the expert reference and operator callbacks create their diagnostic artifacts. Ruff and Python compilation also pass. The full-suite pass is intentionally deferred to the follow-up test-fix review.