Skip to content

chore(fdroid): match rewritemeta's wrapping so our metadata stays diff-clean with fdroiddata - #104

Merged
GeiserX merged 2 commits into
mainfrom
chore/fdroid-binaries-wrap
Nov 7, 2026
Merged

GeiserX merged 2 commits into
mainfrom
chore/fdroid-binaries-wrap

Conversation

@GeiserX

@GeiserX GeiserX commented Nov 7, 2026 •

Copy link
Copy Markdown
Owner

Our copy of the F-Droid metadata keeps the Binaries: URL on one long line. fdroid rewritemeta wraps it onto a second line, and the metadata in the fdroiddata merge request (!56196) already has it wrapped. So our copy and theirs differ, and anyone running rewritemeta on ours gets a diff.

This wraps the line exactly as rewritemeta writes it: Binaries: (with its trailing space), then the URL indented by two spaces. It only changes the formatting. The YAML parses to the same string as before (checked with PyYAML), and no other file changes.

Summary by CodeRabbit

  • Chores
    • Updated the release APK source configuration format; the URL remains unchanged.

…es it

Format only; the parsed value is unchanged. Matches the metadata in the
fdroiddata merge request, so the two copies stay diff-clean.
@coderabbitai

coderabbitai Bot commented Nov 7, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The F-Droid recipe changes Binaries from a scalar to a YAML list. The version-templated release APK URL remains unchanged.

Changes: F-Droid recipe

Layer / File(s) Summary
Binary URL declaration
fdroid/com.cashpilot.android.yml
Binaries now contains the existing release APK URL as a YAML list item.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Possibly related PRs

Merge Risk: Minimal · up to 0f3bc

The metadata change preserves the binary URL and its YAML type. This formatting-only change is ready to merge after normal checks.

Pre-merge checks: Passed 5

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title describes the F-Droid metadata formatting change and its purpose.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 7394f2c and 0f3bcec.

Files selected for processing: 1

  • fdroid/com.cashpilot.android.yml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@GeiserX
GeiserX merged commit 7140d23 into main Nov 7, 2026
5 checks passed
@GeiserX
GeiserX deleted the chore/fdroid-binaries-wrap branch November 7, 2026 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant