Repository navigation
fix(scripts): empty the build cache's temp dir each run so Robolectric leftovers stop filling it - #106
Merged
Conversation
…c leftovers stop filling it
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 48 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#103 moved Java's temp directory into the persistent m2 cache, so Robolectric's jar download becomes an atomic rename. The side effect: Robolectric creates a temp directory per test and often fails to delete it ("Failed to destroy temp directory"). Before, those died with the container. Now they stay in the cache, and one day of screen-test runs left 2.1 GB there.
remote-gradle.shnow empties that directory at the start of each run. A staging file left from a killed run is junk anyway, and the finished jar lives in m2 proper, not in tmp.