Repository navigation
chore(release): ship Android 1.0 alongside CashPilot 2.0 and Desktop 1.0 - #109
Merged
Merged
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 20 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CashPilot Android goes to 1.0, on the same day as CashPilot web 2.0 and Desktop 1.0. The redesign, the WorkManager reporting and the privacy work are all in main, but the version still says 0.4.0, the CHANGELOG has them under Unreleased, and the store text describes the old app.
This PR only prepares the release. It sets
gradle.propertiesto 1.0.0 / 10000, moves the Unreleased entries into a 1.0.0 section with what the redesign added, names the oldest server (1.73.2) and Desktop (0.39.6) releases the phone works with, adds a "What's new in 1.0" block to the README, writes the fastlane changelogchangelogs/10000.txt, and updates the store description. No code changes. The tag comes after merge, once web 2.0 is out.scripts/check-release-version.sh v1.0.0passes on this branch, andv1.0.1fails as it should.F-Droid
The pending fdroiddata MR !56196 doesn't need an edit for 1.0. Its recipe has
UpdateCheckMode: Tags ^v(\d+\.\d+\.\d+)$andAutoUpdateMode: Version. Once it is merged, F-Droid's checkupdates sees thev1.0.0tag, reads 1.0.0 / 10000 fromgradle.propertiesat that tag, and adds the build itself. F-Droid then rebuilds the APK and checks it against ourapp-release.apkbyte for byte, so the 1.0.0 release must keep building reproducibly. No release dependency changed since 0.4.0, andkeepDebugSymbolsis still in place.If we would rather F-Droid launch at 1.0.0 than 0.4.0, the MR's build entry could be switched to the v1.0.0 commit before it is merged. That is optional.
Release body (ready to paste for v1.0.0)