Repository navigation
docs: stop the public CLAUDE.md naming local paths for the signing keystore - #96
Merged
Merged
Conversation
The signing section named where the keystore and its password sit on a maintainer's disk. It now says only that both are kept outside the repository.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 25 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Owner
Author
|
CodeRabbit was rate-limited here, so this was reviewed on a mirror instead: geiresx#1. No actionable comments. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CLAUDE.mdis public, and its signing section gave the local home-directory paths of the release keystore and of the folder that holds its password. The web and Desktop repos removed paths like these earlier (GeiserX/CashPilot#577, GeiserX/CashPilot-Desktop#246); this repo never got the same cleanup.Fix
The section now says the keystore is kept outside the repository and its password is kept with the maintainer's other credentials. The alias and the
KEYSTORE_BASE64secret are unchanged. A search for~/repos,/Users/and machine names finds nothing else in tracked files or commit subjects.Documentation only.