Repository navigation
Conversation
docs/proxies.md said a SOCKS5 proxy carries UDP when the provider supports UDP ASSOCIATE. cp-tunnel lets a socks5 or http tunnel out only over TCP to the proxy's port, so UDP relays are dropped. The page now says SOCKS5 and HTTP CONNECT carry TCP only and a Tailscale exit node carries UDP, matching the comparison page. A test reads the tunnel's egress rule and fails if the page promises UDP through SOCKS5 again.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 33 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #634 +/- ##
=======================================
Coverage 93.97% 93.97%
=======================================
Files 74 74
Lines 15678 15678
=======================================
Hits 14733 14733
Misses 945 945 🚀 New features to boost your workflow:
|
Owner
Author
|
CodeRabbit hit its review limit here, so it reviewed the same head on the mirror geiresx#29. One nitpick: the matcher missed a plain 'SOCKS5 carries UDP'. Fixed in 'test(proxies): also catch a plain SOCKS5 carries UDP claim'. |
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The proxies page says a SOCKS5 proxy "carries UDP only if the provider supports SOCKS5 UDP ASSOCIATE", and that UDP services work through SOCKS5 when the provider supports it. The tunnel does not allow that: for a
socks5orhttpproxy,tunnel/cp-tunnellets traffic out only over TCP to the proxy's address and port (EGRESS_RULE="... ip daddr $PROXY_IP tcp dport $PROXY_PORT accept"). A UDP ASSOCIATE relay sends UDP to the proxy, so the firewall drops it. The comparison page already says "TCP only", so the two pages disagree.Fix
tailscale0traffic is accepted whatever the protocol).We are keeping the tunnel as it is. Opening UDP to the proxy would mean letting the earner reach any UDP port on the proxy host.
Check
tests/test_docs_proxy_udp.pyreads thesocks5 | httpegress rule fromcp-tunneland checks the page. It fails on main's page (test_the_page_does_not_promise_udp_through_socks5). It also fails if the rule is changed to let UDP out, so the test cannot pass on a stale premise.