Repository navigation
Conversation
The guide gave the filing date, the freeze on pre-filing node earnings, the token drop, the exchange exits and the held-back schedule with no source. Each now links Storj's own announcement, its payout update on the official forum, the Storj docs, CoinGecko, Binance and Coinbase. The token drop reads 'more than 98%', which CoinGecko shows today.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 32 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Owner
Author
|
CodeRabbit hit its review limit here, so it reviewed the same head on the mirror geiresx#31. One finding: the test matched a prefix of the filing URL. Fixed: it now checks each full URL up to its closing parenthesis, and a truncated link fails. |
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Storj guide's Chapter 11 warning (
docs/guides/storj.md:12) and its held-back note (:101) state facts with no source: the filing date and court case, the freeze on node earnings from before the filing, the token's drop, the Binance and Coinbase exits, and the 75/50/25% held-back schedule. A reader cannot check them, and when one goes stale nothing points to where to look again.Fix
Each claim now links where it comes from. Every link was opened and checked against the claim:
services/storage/storj.ymlstill says "about 98%" in its description. We left it alone so this PR stays a docs change with no Desktop catalog sync.Check
tests/test_storj_guide_sources.pyrequires the filing and freeze links on the Chapter 11 line, and the docs and freeze links on the held-back line. Both cases fail on main and pass here.