Repository navigation
Conversation
uprock.yml said the minimum was $5 (payment.minimum_payout) and 5 USD (cashout.min_amount), while its own rating con quoted UpRock's help centre: withdrawals are UPT to a Solana wallet from 250 UPT. The payout card counted down to a threshold UpRock does not have. Both fields and the guide now say 250 UPT, with the help centre linked. A catalog test fails when a minimum quoted in a con disagrees with cashout.min_amount and its currency.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 32 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
…vice verification; check payment.minimum_payout too
|
CodeRabbit hit its review limit here, so it reviewed the same head on the mirror geiresx#32. Two findings, both fixed. The guide now says the 250 UPT must be available to withdraw and that Android earnings stay locked until device verification (https://help.uprock.com/en/help/articles/8124029-what-is-device-verification). The catalog test now also checks payment.minimum_payout, with a case that fails when only that field is stale. |
* chore(catalog): sync UpRock's 250 UPT minimum and pending web catalog fixes Vendors services/ from the web branch fix/uprock-minimum-payout (GeiserX/CashPilot#641): UpRock's minimum becomes 250 UPT. The sync also brings the web catalog changes already on web main that Desktop had not picked up yet (earnapp, honeygain, proxybase, proxybase-xyz, repocket). * fix(exchange): price UPT, so the 250 UPT UpRock minimum can be compared The catalog now sets UpRock's minimum in UPT, but UPT had no CoinGecko id, so Desktop could not value a balance against it. Map it to uprock, as the web app does. * fix(exchange): price USDT and USDC, so stablecoin cash-outs count in the totals The cash-out form takes any currency, and ToUSD drops one with no rate. Repocket pays in USDT and Proxybase XYZ in USDC, so those cash-outs fell out of the totals.
Problem
The UpRock entry's minimum payout was wrong.
payment.minimum_payoutsaid"$5"andcashout.min_amountsaid5.0 USD. UpRock's help centre says "The minimum withdrawal is 250 UPT", paid to a Solana wallet once 2FA is on (checked today: https://help.uprock.com/en/articles/2057635-security-and-user-asset-protection-2fa-and-withdrawals). The entry's ownpayout_termscon already quoted that 250 UPT figure, so the file contradicted itself, and the payout card counted down to a $5 threshold UpRock does not have.Fix
services/depin/uprock.yml:minimum_payout: "250 UPT",payment.currency: UPT,cashout.min_amount: 250.0,cashout.currency: UPT. The cashout note says it is a Solana withdrawal that needs 2FA and carries a fee.cashout.currencyis the unit ofmin_amount(see_schema.ymlandtest_beads_batch_23). CashPilot has no UPT rate, somin_payout_inreturns unknown rather than a wrong dollar figure.docs/guides/uprock.md: Minimum payout row is 250 UPT, plus a Withdrawals note that links the help centre.docs/guides/index.mdwas regenerated byscripts/sync_docs_nav.py.signup_urlandcodeare unchanged.Check
tests/test_catalog_minimum_matches_its_cons.pyreads every rating con that quotes a minimum ("$20 minimum", "250 UPT minimum") and requires it to matchcashout.min_amountandcashout.currency. It fails on main foruprockand passes for Honeygain, Earn.fm and UpRock here. Full suite: 7461 passed; the 3 failures need git history and come from running outside a checkout.The Desktop catalog sync PR follows this one.