Repository navigation
Conversation
…e proxy The owner migrator only took containers labelled deployed-by=worker, but CashPilot also counts deployed-by=direct as its own. On a host with such earners the fence network was left unlabelled and the earners dropped out of the worker's view. They now count as ours, and each is recreated with the worker label (with its volumes moved when they need it).
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 2 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #646 +/- ##
=======================================
Coverage 93.97% 93.98%
=======================================
Files 74 74
Lines 15686 15698 +12
=======================================
+ Hits 14741 14753 +12
Misses 945 945
🚀 New features to boost your workflow:
|
This was referenced Nov 7, 2026
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a host that still runs earners from the deploy path before workers (label
cashpilot.deployed-by=direct), the owner migration left them alone. CashPilot countsdirectas its own everywhere else (constants.CASHPILOT_DEPLOYED), but the migrator only tookworker. So the fence network they sit on stayed unlabelled, and once the socket proxy started, those earners vanished from the worker.The migrator now treats
directcontainers as CashPilot's:directearner on the fence network no longer blocks the network from being relabelled;directearner is recreated withcashpilot.deployed-by=worker, the only way Docker allows to change a container's labels. If it has unlabelled volumes they move in the same plan, with the same backup and checks as before. If it has none, the plan just stops, removes and recreates it as it was.A container that is neither
workernordirectis still left alone, as before.Test:
test_earners_the_pre_worker_deploy_path_made_are_adopted_with_the_fencefailed on main (the network was left alone with a warning) and passes here; the other 35 migrator tests still pass.Desktop: nothing to port. Desktop has no socket proxy or owner migration.