Skip to content

fix(update): stop sending deployer-run stacks to a compose path that is not on the host - #648

Closed
GeiserX wants to merge 1 commit into
mainfrom
fix/update-advice-under-deployer
Closed

GeiserX wants to merge 1 commit into
mainfrom
fix/update-advice-under-deployer

Conversation

@GeiserX

@GeiserX GeiserX commented Nov 7, 2026

Copy link
Copy Markdown
Owner

When the in-app Update refuses behind the socket proxy, it tells the operator to add CASHPILOT_COMPOSE_DIR=<path> to the .env, taking the path from Compose's working_dir label. If a webhook or a deployer container (Portainer and the like) runs Compose for them, that label holds the path inside the deployer, which may not exist on the host. The advice then pointed at a wrong folder.

No other value would help in that case: the update helper binds that exact path to find the compose file, so the update can only work when Compose's path is also a real host path. The message now:

  • says the path is what Docker Compose recorded;
  • says that if Compose runs inside another container, the path is inside that container and the stack should be updated from the deployer;
  • still gives the line to paste for the normal case.

Test: test_proxied_under_a_deployer_container_the_refusal_does_not_pass_its_path_off_as_the_hosts failed on main and passes here; tests/test_socket_proxy.py and tests/test_update_feature.py pass (185 tests).

Desktop: nothing to port. Desktop has no in-app compose update or socket proxy.

…hat is not on the host

When Compose runs inside a webhook or deployer container, the working_dir
label holds the deployer's own path. The refusal told the operator to set
CASHPILOT_COMPOSE_DIR to it as if it were the host folder. It now names the
path as what Compose recorded and says to update from the deployer in that
case.
@coderabbitai

coderabbitai Bot commented Nov 7, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 12 seconds.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

Commits

Reviewing files that changed from the base of the PR and between a4c867f and 327ad50.

Files selected for processing: 2

  • app/orchestrator.py
  • tests/test_socket_proxy.py
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@GeiserX

GeiserX commented Nov 7, 2026

Copy link
Copy Markdown
Owner Author

Landed in #653 (f681889), which combined this fix with the others into one release.

@GeiserX GeiserX closed this Nov 7, 2026
@GeiserX
GeiserX deleted the fix/update-advice-under-deployer branch November 7, 2026 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant