Repository navigation
test: stop the changelog check from blocking on the 2.0 release entry - #658
Merged
Merged
Conversation
The bookkeeping check matched any entry starting with "Release" and a digit, so the real feature "Release 2.0, because upgrading from 1.x now needs a step" failed it and blocked the CHANGELOG regeneration PR. It now matches only a bare version line.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 59 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CHANGELOG regeneration PR (#655) fails one test. The check looks for release bookkeeping lines leaking into the changelog, and its pattern matched any entry that starts with "Release" and a digit. The 2.0 feature entry, "Release 2.0, because upgrading from 1.x now needs a step (#652)", is a real change, not bookkeeping, so it tripped the check.
The pattern now matches only a bare version line such as "Release v2.0.0" or "Release 1.73.4 (#640)", plus "chore(release)". Checked against #655's CHANGELOG: the old pattern flags the 2.0 entry, the new one flags nothing, and all three bookkeeping shapes still match.
Test-only change, so it cuts no release.