Repository navigation
fix(deps): stop trusting certificates minted with the leaked eMudhra keys - #655
Merged
Merged
Conversation
…keys Eight eMudhra (emSign) intermediates had recoverable private keys and were revoked on 2026-10-18 for key compromise. Both TLS clients here trust webpki-roots: ureq (tnet update, tailnetd debug --get-url, the captive portal check) and the engine's ts_tls_util (control plane, DERP). With webpki-roots 1.0.7, `tailnetd debug --get-url https://dv-g3b-emudhra.we-have-a-problem.com/` from the 0.68.4 release printed the test page's "Your client successfully connected to the site". webpki-roots 1.0.10 drops emSign ECC Root CA - G3, and rustls-webpki 0.103.16 distrusts the eight intermediates themselves. Signed-off-by: GeiserX <9169332+GeiserX@users.noreply.github.com>
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters: 1
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eight eMudhra (emSign) intermediates had recoverable private keys and were revoked on 2026-10-18 for key compromise. Anyone can mint a certificate for any name under them, and no client checks the revocation. Both TLS clients in tailscaled-rs trust
webpki-roots: ureq (tnet update,tailnetd debug --get-url, the captive portal check) and the engine'sts_tls_util(control plane and DERP). The 0.68.4 release, with webpki-roots 1.0.7, connects to a host served through one of those intermediates:The fix
Lockfile only:
Checks
The same two bumps in tailscale-rs (GeiserX/tailscale-rs#655), through
ts_tls_util::connect: the emSign host and the Sectigo AAA cross-sign host both fail withCertDistrusted, and github.com still connects. Before, the emSign host connected. Once this ships I will run the releasedtailnetd debug --get-urlagainst both hosts and github.com.