Repository navigation
fix(agt): validate Guardian decision responses - #249
Draft
mjatin2007 wants to merge 1 commit into
Draft
mjatin2007 wants to merge 1 commit into
mjatin2007 wants to merge 1 commit into
Conversation
Signed-off-by: Jatin Mannepalli <mjatin2007@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Validates parsed, correlated Guardian decision responses against the canonical
response-envelope.jsonschema and its method-specificAcsResultbranch before the host adapter accepts them. A canonical-schema or method-result violation is audited and denied even underon_decision_failure: proceed; inability to run the local validator remains a host-side failure and follows the negotiated posture.This follows the accepted issue's fail-closed direction, but under
proceedit deliberately differs from the literal current §6.4 treatment of a malformed response. Validation covers the complete canonical response envelope, not onlydeny.reasoning. This draft should not be treated as conformant until §6.4 is clarified, and it should not merge ahead of that clarification unless maintainers direct otherwise. Response-signature verification is separate and remains pending in #229.Which issue does this implement
Part of #182
meaning, so it needs no issue
Base branch
integration, because this touches the specification, schemas, a referenceimplementation, an adapter, tests, or CI
main, because every changed path is on the documentation lane allowlist inCONTRIBUTING.md
Type of change
I tested this
uv run pytest -vpasses on my machineuv run mkdocs build --strictpasses on my machineThe AGT validation also passes on the repository's pinned Bun 1.3.11: TypeScript succeeds, and the complete Bun suite reports 1,123 passed, 1 skipped, 0 failed across 68 files.
Checklist
git commit -s(required by the DCO)Security
Security impact: schema-invalid or method-invalid Guardian responses are blocked and audited. Local validator unavailability remains posture-governed and is attributed to the host rather than the Guardian.