reformat uiController.js to fit style guidelines - #194
Open
natpuck wants to merge 1 commit into
Open
Conversation
Based on style_guidelines.md (updated: line length and wrapping, function header comments, in-line comments)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on style_guidelines.md (updated: line length and wrapping, function header comments, in-line comments)
name: reformat uiController.js to fit style guidelines
about: GenderMag Recorders Assistant project
What does this implementation fix? Explain your changes.
This implementation brings the code within uiController.js inline with the style guidelines outlined in style_guidelines.md.
Does this close any open issue? (Give issue id from issue tracker)
This PR works toward closing issue Reformat code to meet style guidlines #89
Include any related logs, error, output file etc.
N/A
Did you test on Mac and Windows?
I tested on Windows, but don't have access to a Mac device.
Did you test the full GM process and verify that the code does not contribute any unexpected errors/bugs?
*Yes.
Did you follow the style guidelines and verify that the code does not have any incorrect formatting?
Yes.
If possible, provide a screenshot of the functionality.
N/A since no functionality was changed.
Any other information?
I didn't add a function header comment to reloadSandwich() due to the "TODO" comment above it stating the desire to refactor it. There were some comments above that one stating confusion about when the function is called, so all of this combined is why this is the only function without a header comment.