Merged
Conversation
suragnair
approved these changes
Sep 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improvements to motif scanning, especially to the
compare_motifsfunction.scan_sequences, the argumentnameswas not being propagated. Fixed.compare_motifs, the argumentrcwas not being propagated. Fixed.compare_motifs, the docstring contained an argumentref_allelewhich does not exist. Removed.compare_motifswould previously return an error if no motifs are found. I added a conditionif len(scan) > 0:.compare_motifspreviously would scan both ref and alt sequences using the thresholdpthreshand return the motif match scores in both. If a motif match was above the threshold in one sequence but not the other, it would only return one score and would return NA for the other. Now, I added an extra scanning step which will fill in sub-threshold p-values.compare_motifspreviously would return only match scores for motifs in the ref and alt sequences. Now, it returns both match scores and p-values.compare_motifspreviously would return the ratio of match scores in alt vs. ref sequences. Since motif match scores are on a log scale, I changed this to the difference.compare_motifs