Merged
Conversation
Contributor
Code Coverage SummaryDiff against mainResults for commit: 7686e68 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Contributor
Unit Test Performance Difference
Additional test case details
Results for commit 03a68c1 ♻️ This comment has been updated with latest results. |
danielinteractive
previously approved these changes
Feb 20, 2025
Collaborator
danielinteractive
left a comment
There was a problem hiding this comment.
Looks great, thanks @gowerc , would it be worth to add a NEWS entry?
Contributor
Author
|
@danielinteractive - Good point, though I took this moment to add all the missing news items that I had neglected to add over the last couple of PRs 😓 |
danielinteractive
previously approved these changes
Feb 20, 2025
Collaborator
danielinteractive
left a comment
There was a problem hiding this comment.
Nice! Thanks @gowerc
Contributor
Unit Tests Summary 1 files 180 suites 5m 43s ⏱️ Results for commit 7686e68. ♻️ This comment has been updated with latest results. |
gravesti
approved these changes
Feb 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #431
Added wrapper
saveObject()method that takes care of ensuring the samples are correctly saving along with the object.