Skip to content

W3DTreeBuffer: Add null check for unit in unitMoved to prevent crashes #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
seer-by-sentry wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −0
Open

W3DTreeBuffer: Add null check for unit in unitMoved to prevent crashes #103

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions GeneralsMD/Code/GameEngineDevice/Source/W3DDevice/GameClient/W3DTreeBuffer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1140,6 +1140,11 @@ void W3DTreeBuffer::freeTreeBuffers(void)
//=============================================================================
void W3DTreeBuffer::unitMoved(Object *unit)
{
// Null pointer check to prevent crash when invalid Object pointer is passed
if (unit == NULL) {
return;
}

if (unit->isKindOf(KINDOF_IMMOBILE)) {
// This is the initial positioning of the object, and we don't care. jba. [6/5/2003]
return;
Expand Down Expand Up @@ -2045,3 +2050,7 @@ void W3DTreeBuffer::loadPostProcess( void )







Loading