HTTP: Prevent use-after-free in HTTPRequest callback during shutdown - #104
Open
seer-by-sentry[bot] wants to merge 1 commit into
Open
HTTP: Prevent use-after-free in HTTPRequest callback during shutdown#104seer-by-sentry[bot] wants to merge 1 commit into
seer-by-sentry[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes CLIENT-PP. The issue was that: HTTPManager::Shutdown invokes callbacks capturing deleted objects, causing access violation in
std::function::operator().m_bSkipCallbacktoHTTPRequestto skip the completion callback invocation.m_bSkipCallbackto true when a request is completed during HTTPManager shutdown.m_bSkipCallbackinHTTPRequest::Threaded_SetCompletebefore invoking the callback.This fix was generated by Seer in Sentry, triggered automatically. 👁️ Run ID: 2314476
Not quite right? Click here to continue debugging with Seer.