Skip to content

OnlineServices: Implement graceful shutdown of HTTP requests - #106

Open
seer-by-sentry[bot] wants to merge 1 commit into
mainfrom
seer/graceful-http-shutdown
Open

OnlineServices: Implement graceful shutdown of HTTP requests#106
seer-by-sentry[bot] wants to merge 1 commit into
mainfrom
seer/graceful-http-shutdown

Conversation

@seer-by-sentry

@seer-by-sentry seer-by-sentry Bot commented Nov 1, 2025

Copy link
Copy Markdown

Fixes CLIENT-QE. The issue was that: HTTP request callback invoked during shutdown accesses destroyed manager object captured by value, causing an access violation.

  • Modified HTTPRequest to allow skipping callback invocation during completion, controlled by a new m_bSkipCallback flag.
  • Modified Threaded_SetComplete to accept a bSkipCallback parameter, setting the flag accordingly.
  • Modified HTTPManager to skip callback invocation when completing requests during shutdown to prevent use-after-free issues.
  • Added safety checks in the HTTPRequest destructor to ensure the HTTPManager is still valid before attempting to remove the handle from the multi-handle.
  • Modified the artificial delay logic to invoke callbacks during normal operation.

This fix was generated by Seer in Sentry, triggered automatically. 👁️ Run ID: 2352235

Not quite right? Click here to continue debugging with Seer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants