Skip to content

OnlineServices: Ensure HTTPManager is deleted before interface objects - #108

Open
seer-by-sentry[bot] wants to merge 1 commit into
mainfrom
seer/fix-online-services-shutdown
Open

OnlineServices: Ensure HTTPManager is deleted before interface objects#108
seer-by-sentry[bot] wants to merge 1 commit into
mainfrom
seer/fix-online-services-shutdown

Conversation

@seer-by-sentry

@seer-by-sentry seer-by-sentry Bot commented Nov 3, 2025

Copy link
Copy Markdown

Fixes CLIENT-QP. The issue was that: HTTP request callback executes after its captured interface object is deleted during NGMP_OnlineServicesManager shutdown, causing use-after-free.

  • Modified the NGMP_OnlineServicesManager destructor to delete the HTTPManager before deleting other interface objects.
  • This ensures that completion callbacks invoked during HTTPManager::Shutdown() do not reference invalid interface objects.
  • Cleared the completion callback in HTTPRequest after invocation to prevent use-after-free issues during shutdown.

This fix was generated by Seer in Sentry, triggered automatically. 👁️ Run ID: 2359009

Not quite right? Click here to continue debugging with Seer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants