Skip to content

TextureLoadTask: Guard against NULL D3DTexture pointer dereference during surface locking - #163

Open
seer-by-sentry[bot] wants to merge 1 commit into
mainfrom
seer/textureloader-d3dtexture-null-guard
Open

TextureLoadTask: Guard against NULL D3DTexture pointer dereference during surface locking#163
seer-by-sentry[bot] wants to merge 1 commit into
mainfrom
seer/textureloader-d3dtexture-null-guard

Conversation

@seer-by-sentry

Copy link
Copy Markdown

Fixes CLIENT-126. The issue was that: Texture loading failed to create D3D resource, but Finish_Load logic ignored failure, causing NULL pointer dereference in Lock_Surfaces.

  • Added null pointer checks for D3DTexture in TextureLoadTaskClass::Lock_Surfaces.
  • Added null pointer checks for D3DTexture in CubeTextureLoadTaskClass::Lock_Surfaces.
  • Added null pointer checks for D3DTexture in VolumeTextureLoadTaskClass::Lock_Surfaces.
  • Prevents crashes if D3DTexture is unexpectedly NULL when attempting to lock surfaces.

This fix was generated by Seer in Sentry, triggered automatically. 👁️ Run ID: 7801678

Not quite right? Click here to continue debugging with Seer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants