Skip to content

WW3D2: Add delay before resource release to mitigate D3D12 translation layer crashes #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
seer-by-sentry wants to merge 1 commit into
base: main
Choose a base branch
from
+14 −0
Open

WW3D2: Add delay before resource release to mitigate D3D12 translation layer crashes #175

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions Generals/Code/Libraries/Source/WWVegas/WW3D2/dx8wrapper.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1681,6 +1681,13 @@ void DX8Wrapper::End_Scene(bool flip_frames)
}
}

// TheSuperHackers @bugfix 01/2025
// Add delay before releasing resources to allow GPU to complete pending operations.
// This mitigates race conditions in the D3D9-to-D3D12 translation layer on Windows 10+
// where the GPU may still be processing commands from the current frame when the CPU
// releases vertex/index buffers, causing access violations in CViewBoundState::IsDirty.
ThreadClass::Sleep_Ms(50);

// Each frame, release all of the buffers and textures.
Set_Vertex_Buffer(NULL);
Set_Index_Buffer(NULL,0);
Expand Down
7 changes: 7 additions & 0 deletions GeneralsMD/Code/Libraries/Source/WWVegas/WW3D2/dx8wrapper.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1844,6 +1844,13 @@ void DX8Wrapper::End_Scene(bool flip_frames)
}
}

// TheSuperHackers @bugfix 01/2025
// Add delay before releasing resources to allow GPU to complete pending operations.
// This mitigates race conditions in the D3D9-to-D3D12 translation layer on Windows 10+
// where the GPU may still be processing commands from the current frame when the CPU
// releases vertex/index buffers, causing access violations in CViewBoundState::IsDirty.
ThreadClass::Sleep_Ms(50);

// Each frame, release all of the buffers and textures.
Set_Vertex_Buffer(NULL);
Set_Index_Buffer(NULL,0);
Expand Down
Loading