Skip to content

Enable slow mode for chat in main lobby menu to prevent spam #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
x64-dev merged 1 commit into from
Jan 2, 2026
Merged

Enable slow mode for chat in main lobby menu to prevent spam #191

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 43 additions & 0 deletions GeneralsMD/Code/GameEngine/Source/GameClient/GUI/GUICallbacks/Menus/WOLLobbyMenu.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,41 @@ static Int groupRoomToJoin = 0;
static Int initialGadgetDelay = 2;
static Bool justEntered = FALSE;

static int64_t s_lobbyLastChatTimeMs = 0;
static const int64_t S_LOBBY_CHAT_INTERVAL_MS = 4000; // how long to wait before we allow sending the next message

static bool LobbyChatSlowmodeAllowsSend()
{
using namespace std::chrono;

int64_t nowMs =
duration_cast<milliseconds>(utc_clock::now().time_since_epoch()).count();

if (nowMs < s_lobbyLastChatTimeMs)
{
s_lobbyLastChatTimeMs = 0;
}

int64_t delta = nowMs - s_lobbyLastChatTimeMs;
if (delta < S_LOBBY_CHAT_INTERVAL_MS)
{
if (listboxLobbyChat)
{
GadgetListBoxAddEntryText(
listboxLobbyChat,
UnicodeString(L"You are sending messages too quickly. Please wait a moment."),
GameMakeColor(255, 0, 0, 255),
-1,
-1
);
}
return false;
}

s_lobbyLastChatTimeMs = nowMs;
return true;
}

#if defined(RTS_DEBUG)
Bool g_fakeCRC = FALSE;
Bool g_debugSlots = FALSE;
Expand Down Expand Up @@ -2484,6 +2519,10 @@ WindowMsgHandledType WOLLobbyMenuSystem( GameWindow *window, UnsignedInt msg,
txtInput.trim();
if (!txtInput.isEmpty())
{
if (!LobbyChatSlowmodeAllowsSend())
{
break;
}
// Send the message
NGMP_OnlineServices_RoomsInterface* pRoomsInterface = NGMP_OnlineServicesManager::GetInterface<NGMP_OnlineServices_RoomsInterface>();
if (pRoomsInterface != nullptr)
Expand Down Expand Up @@ -2873,6 +2912,10 @@ WindowMsgHandledType WOLLobbyMenuSystem( GameWindow *window, UnsignedInt msg,
// Send the message
if (!handleLobbySlashCommands(txtInput))
{
if (!LobbyChatSlowmodeAllowsSend())
{
break;
}
std::shared_ptr<WebSocket> pWS = NGMP_OnlineServicesManager::GetWebSocket();
if (pWS != nullptr)
{
Expand Down
Loading