Ensure player assets are removed/transfered after they quit on DC menu - #203
Merged
x64-dev merged 1 commit intoJan 4, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a player quit using the dc menu (quit game button), the game only sent a disconnect message that removed the player from the match, but it never told the other clients to actually destroy that player’s units. Because of that, the quitting player’s army stayed on the map for everyone else.
This fix checks if the player who sent the disconnect is the same player being disconnected. If so, it means they quit on purpose, so we send the normal “destroy player” command before disconnecting them. That makes all clients clean up the player’s units (or transfer to teammates) just like a regular quit