Skip to content

Fix division by zero in power bar GUI updates #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
seer-by-sentry wants to merge 1 commit into
base: main
Choose a base branch
from
+30 −0
Open

Fix division by zero in power bar GUI updates #204

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions ...rals/Code/GameEngineDevice/Source/W3DDevice/GameClient/GUI/GUICallbacks/W3DControlBar.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,10 @@ void W3DPowerDraw( GameWindow *window, WinInstanceData *instData )
if( !slider || !centerBar)
return;

// Validate image dimensions to prevent division by zero
if( centerBar->getImageWidth() <= 0 )
return;

Int range;
range = logN(production, TheGlobalData->m_powerBarBase) * (size.x / TheGlobalData->m_powerBarIntervals);
if(range >= size.x)
Expand Down Expand Up @@ -338,6 +342,10 @@ void W3DPowerDrawA( GameWindow *window, WinInstanceData *instData )
if( !slider || !endBar || !beginBar || !centerBar)
return;

// Validate image dimensions to prevent division by zero
if( centerBar->getImageWidth() <= 0 )
return;

Int range;
range = logN(production, TheGlobalData->m_powerBarBase) * (size.x / TheGlobalData->m_powerBarIntervals);
if(range >= size.x)
Expand Down Expand Up @@ -516,6 +524,10 @@ void W3DCommandBarGenExpDraw( GameWindow *window, WinInstanceData *instData )
if( !endBar || !beginBar || !centerBar)
return;

// Validate image dimensions to prevent division by zero
if( centerBar->getImageHeight() <= 0 )
return;

Int range;
range = size.y * progress / 100;

Expand Down Expand Up @@ -928,6 +940,9 @@ void W3DCommandBarHelpPopupDraw( GameWindow *window, WinInstanceData *instData )
if( !endBar || !beginBar || !centerBar)
return;

// Validate image dimensions to prevent division by zero
if( centerBar->getImageHeight() <= 0 )
return;

// Int range;
// range = size.y;
Expand Down
15 changes: 15 additions & 0 deletions ...lsMD/Code/GameEngineDevice/Source/W3DDevice/GameClient/GUI/GUICallbacks/W3DControlBar.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,10 @@ void W3DPowerDraw( GameWindow *window, WinInstanceData *instData )
if( !slider || !centerBar)
return;

// Validate image dimensions to prevent division by zero
if( centerBar->getImageWidth() <= 0 )
return;

Int range;
range = logN(production, TheGlobalData->m_powerBarBase) * (size.x / TheGlobalData->m_powerBarIntervals);
if(range >= size.x)
Expand Down Expand Up @@ -338,6 +342,10 @@ void W3DPowerDrawA( GameWindow *window, WinInstanceData *instData )
if( !slider || !endBar || !beginBar || !centerBar)
return;

// Validate image dimensions to prevent division by zero
if( centerBar->getImageWidth() <= 0 )
return;

Int range;
range = logN(production, TheGlobalData->m_powerBarBase) * (size.x / TheGlobalData->m_powerBarIntervals);
if(range >= size.x)
Expand Down Expand Up @@ -516,6 +524,10 @@ void W3DCommandBarGenExpDraw( GameWindow *window, WinInstanceData *instData )
if( !endBar || !beginBar || !centerBar)
return;

// Validate image dimensions to prevent division by zero
if( centerBar->getImageHeight() <= 0 )
return;

Int range;
range = size.y * progress / 100;

Expand Down Expand Up @@ -928,6 +940,9 @@ void W3DCommandBarHelpPopupDraw( GameWindow *window, WinInstanceData *instData )
if( !endBar || !beginBar || !centerBar)
return;

// Validate image dimensions to prevent division by zero
if( centerBar->getImageHeight() <= 0 )
return;

// Int range;
// range = size.y;
Expand Down
Loading