Skip to content

Implement AddRef/Release using atomic ref counting for ConnectionSignaling - #214

Open
seer-by-sentry[bot] wants to merge 1 commit into
mainfrom
seer/refactor/atomic-ref-count-signaling
Open

Implement AddRef/Release using atomic ref counting for ConnectionSignaling#214
seer-by-sentry[bot] wants to merge 1 commit into
mainfrom
seer/refactor/atomic-ref-count-signaling

Conversation

@seer-by-sentry

@seer-by-sentry seer-by-sentry Bot commented Jan 4, 2026

Copy link
Copy Markdown

Fixes CLIENT-1J8. The issue was that: Steam signaling object's Release method incorrectly calls delete this, corrupting WRL state and causing a subsequent division by zero.

  • Implemented thread-safe reference counting (AddRef/Release) for the ConnectionSignaling class.
  • Added std::atomic m_refCount to manage the reference count.
  • ConnectionSignaling now correctly self-destructs only when the reference count reaches zero in Release().

This fix was generated by Seer in Sentry, triggered automatically. 👁️ Run ID: 8134759

Not quite right? Click here to continue debugging with Seer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants