Skip to content

Use vsnprintf for safe debug string formatting #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
seer-by-sentry wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

Use vsnprintf for safe debug string formatting #216

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Core/Libraries/Source/debug/debug_debug.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,7 @@

void Debug::InstallExceptionHandler(void)
{
_set_se_translator(LocalSETranslator);

Check warning on line 263 in Core/Libraries/Source/debug/debug_debug.cpp

View workflow job for this annotation

GitHub Actions / Build GeneralsMD / win32-profile+e 

 calling _set_se_translator() requires /EHa

Check warning on line 263 in Core/Libraries/Source/debug/debug_debug.cpp

View workflow job for this annotation

GitHub Actions / Build GeneralsMD / win32+e 

 calling _set_se_translator() requires /EHa
}

bool Debug::SkipNext(void)
Expand Down Expand Up @@ -1254,7 +1254,7 @@
// potentially dangerous (fixed string buffer...)
va_list va;
va_start(va,fmt);
wvsprintf(curSource,fmt,va);
vsnprintf(curSource,sizeof(curSource),fmt,va);
va_end(va);
__ASSERT(curSource[sizeof(curSource)-1]==0);
}
Expand Down
Loading