Skip to content

Prevent division by zero in particle emitter frametime calculation #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
seer-by-sentry wants to merge 1 commit into
base: main
Choose a base branch
from
+20 −8
Open

Prevent division by zero in particle emitter frametime calculation #220

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions Generals/Code/Libraries/Source/WWVegas/WW3D2/part_emt.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -554,11 +554,17 @@ void ParticleEmitterClass::Create_New_Particles(const Quaternion & curr_quat, co
if (frametime > 100 * EmitRate) { // If the loop will run over 100 times
unsigned int buf_size = Buffer->Get_Buffer_Size();
unsigned int gcd = Greatest_Common_Divisor(buf_size, BurstSize);
unsigned int bursts = buf_size / gcd;
unsigned int cycle_time = EmitRate * bursts;
if (cycle_time > 1) {
frametime = frametime % cycle_time;
// Prevent division by zero - if gcd is 0, the buffer/burst parameters are degenerate
if (gcd > 0) {
unsigned int bursts = buf_size / gcd;
unsigned int cycle_time = EmitRate * bursts;
if (cycle_time > 1) {
frametime = frametime % cycle_time;
} else {
frametime = 1;
}
} else {
// Degenerate case: buffer size and burst size are both 0
frametime = 1;
}
}
Expand Down
14 changes: 10 additions & 4 deletions GeneralsMD/Code/Libraries/Source/WWVegas/WW3D2/part_emt.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -563,11 +563,17 @@ void ParticleEmitterClass::Create_New_Particles(const Quaternion & curr_quat, co
if (frametime > 100 * EmitRate) { // If the loop will run over 100 times
unsigned int buf_size = Buffer->Get_Buffer_Size();
unsigned int gcd = Greatest_Common_Divisor(buf_size, BurstSize);
unsigned int bursts = buf_size / gcd;
unsigned int cycle_time = EmitRate * bursts;
if (cycle_time > 1) {
frametime = frametime % cycle_time;
// Prevent division by zero - if gcd is 0, the buffer/burst parameters are degenerate
if (gcd > 0) {
unsigned int bursts = buf_size / gcd;
unsigned int cycle_time = EmitRate * bursts;
if (cycle_time > 1) {
frametime = frametime % cycle_time;
} else {
frametime = 1;
}
} else {
// Degenerate case: buffer size and burst size are both 0
frametime = 1;
}
}
Expand Down
Loading