Skip to content

Fix: Add null checks for Coord3D pointers to prevent crashes #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
seer-by-sentry wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: Add null checks for Coord3D pointers to prevent crashes #78

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions Generals/Code/GameEngine/Source/Common/Thing/Thing.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,13 @@ void Thing::setPositionZ( Real z )
//=============================================================================
void Thing::setPosition( const Coord3D *pos )
{
// Validate position pointer to prevent null pointer dereference
if( pos == NULL )
{
DEBUG_CRASH(( "Thing::setPosition called with NULL position pointer" ));
return;
}

//USE_PERF_TIMER(ThingMatrixStuff)
if( !m_template->isKindOf( KINDOF_STICK_TO_TERRAIN_SLOPE) )
{
Expand Down
4 changes: 4 additions & 0 deletions Generals/Code/GameEngine/Source/GameLogic/Object/SpecialPower/SpecialPowerModule.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -434,6 +434,10 @@ void SpecialPowerModule::triggerSpecialPower( const Coord3D *location )
//-------------------------------------------------------------------------------------------------
void SpecialPowerModule::createViewObject( const Coord3D *location )
{
// Validate location pointer to prevent null pointer dereference
if( location == NULL )
return;

const SpecialPowerModuleData *modData = getSpecialPowerModuleData();
const SpecialPowerTemplate *powerTemplate = modData->m_specialPowerTemplate;

Expand Down
7 changes: 7 additions & 0 deletions GeneralsMD/Code/GameEngine/Source/Common/Thing/Thing.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,13 @@ void Thing::setPositionZ( Real z )
//=============================================================================
void Thing::setPosition( const Coord3D *pos )
{
// Validate position pointer to prevent null pointer dereference
if( pos == NULL )
{
DEBUG_CRASH(( "Thing::setPosition called with NULL position pointer" ));
return;
}

//USE_PERF_TIMER(ThingMatrixStuff)
if( !m_template->isKindOf( KINDOF_STICK_TO_TERRAIN_SLOPE) )
{
Expand Down
4 changes: 4 additions & 0 deletions GeneralsMD/Code/GameEngine/Source/GameLogic/Object/SpecialPower/SpecialPowerModule.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -493,6 +493,10 @@ void SpecialPowerModule::triggerSpecialPower( const Coord3D *location )
//-------------------------------------------------------------------------------------------------
void SpecialPowerModule::createViewObject( const Coord3D *location )
{
// Validate location pointer to prevent null pointer dereference
if( location == NULL )
return;

const SpecialPowerModuleData *modData = getSpecialPowerModuleData();
const SpecialPowerTemplate *powerTemplate = modData->m_specialPowerTemplate;

Expand Down
Loading