Skip to content

AIGroup: Advance iterator before calling doCommandButton - #79

Open
seer-by-sentry[bot] wants to merge 1 commit into
mainfrom
seer/fix-aigroup-iterator
Open

AIGroup: Advance iterator before calling doCommandButton#79
seer-by-sentry[bot] wants to merge 1 commit into
mainfrom
seer/fix-aigroup-iterator

Conversation

@seer-by-sentry

Copy link
Copy Markdown

Fixes CLIENT-GT. The issue was that: Iterating over AIGroup::m_memberList while executing Object::doCommandButton allows object self-destruction, causing list modification and iterator invalidation, leading to an access violation.

  • Fixes a potential crash where the object being iterated over in the AIGroup's member list is destroyed during the doCommandButton call.
  • The iterator is now incremented before the call to doCommandButton to prevent issues when the object removes itself from the list.

This fix was generated by Seer in Sentry, triggered automatically. 👁️ Run ID: 1964834

Not quite right? Click here to continue debugging with Seer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants