Skip to content

ChallengeLoadScreen: Add safety checks for NULL generalOpponent - #82

Open
seer-by-sentry[bot] wants to merge 1 commit into
mainfrom
seer/fix/challenge-load-screen-null-check
Open

ChallengeLoadScreen: Add safety checks for NULL generalOpponent#82
seer-by-sentry[bot] wants to merge 1 commit into
mainfrom
seer/fix/challenge-load-screen-null-check

Conversation

@seer-by-sentry

Copy link
Copy Markdown

Fixes CLIENT-HG. The issue was that: Null GeneralPersona pointer dereferenced during AudioEventRTS construction, causing fatal read access violation (0x64).

  • Added null checks for generalOpponent in ChallengeLoadScreen::activatePieces, ChallengeLoadScreen::activatePiecesMinSpec, and ChallengeLoadScreen::setupLoadScreen to prevent potential crashes when the opponent general data is missing.
  • Added a check in ChallengeLoadScreen::setupLoadScreen to log an error if the GeneralPersona for the opponent cannot be found, and return early to prevent further operations with a null pointer.
  • Added a null check before playing the opponent's taunt sound to avoid crashes if generalOpponent is null.

This fix was generated by Seer in Sentry, triggered automatically. 👁️ Run ID: 2014261

Not quite right? Click here to continue debugging with Seer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants