Skip to content

AssetMgr: Add SEH protection against accessing freed prototype pointers - #83

Open
seer-by-sentry[bot] wants to merge 1 commit into
mainfrom
seer/fix-assetmgr-dangling-pointers
Open

AssetMgr: Add SEH protection against accessing freed prototype pointers#83
seer-by-sentry[bot] wants to merge 1 commit into
mainfrom
seer/fix-assetmgr-dangling-pointers

Conversation

@seer-by-sentry

Copy link
Copy Markdown

Fixes CLIENT-HS. The issue was that: Prototype hash table traversal uses dangling pointer to deleted object's name, causing read access violation in __ascii_stricmp.

  • Added a defensive check using Structured Exception Handling (SEH) to protect against accessing freed/invalid PrototypeClass pointers in the PrototypeHashTable.
  • The SEH __try and __except block catches access violations that may occur when dereferencing dangling pointers in the hash chain.
  • If an access violation is caught, the loop is broken to prevent further traversal of the potentially corrupted hash chain, mitigating use-after-free scenarios.

This fix was generated by Seer in Sentry, triggered automatically. 👁️ Run ID: 2020459

Not quite right? Click here to continue debugging with Seer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants