Conversation
|
|
||
| const ListContainer = styled.div<{ withScroll?: boolean }>` | ||
| display: flex; | ||
| padding-bottom: ${$paddingXsmall}px; |
There was a problem hiding this comment.
HorizontalShadowList is used not only in the dashboard. This change will affect other places as well.
| display: flex; | ||
| padding-bottom: ${$paddingXsmall}px; | ||
| padding-bottom: ${({ withScroll = true }) => | ||
| withScroll ? `${$paddingXsmall}px` : ""}; |
There was a problem hiding this comment.
HorizontalShadowList is used not only in the dashboard. This change will affect other places as well.
|
Now, it only affects three components in dashboard page as it should be. And it doesn't affect the message component. |
|
HorizontalShadowList doesn't need this change. If the dashboard needs this strange change then create expanded HorizontalShadowList in the dashboard folder and use it. |
|
I don't understand why this is "strange change". If there is a scroll, HorizontalShadowList should always have an indent between scroll and content. And my change doesn't affect other cases. |
pavelzubov
left a comment
pavelzubov
left a comment
There was a problem hiding this comment.
Because I don't see reasons for this change) Create a separate component in the dashboard folder and use it.
|
|
||
| &__shadow-wrapper { | ||
| @include details-block-left-margin(); | ||
| @include details-block-right-margin(); |
There was a problem hiding this comment.
The task doesn't require this change
2 participants
No description provided.