Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 42b212de2e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
build/Linux/CMakeLists.txt
Outdated
| INSTALL_DIR ${BOOST_ROOT} | ||
|
|
||
| CONFIGURE_COMMAND <SOURCE_DIR>/bootstrap.sh --with-toolset=clang --with-libraries=${BOOST_INCLUDE_LIBRARIES_COMMA_SEPARATED} --prefix=${BOOST_ROOT} | ||
| CONFIGURE_COMMAND <SOURCE_DIR>/bootstrap.sh --with-toolset=clang --without-python --with-libraries=${BOOST_INCLUDE_LIBRARIES_COMMA_SEPARATED} --prefix=${BOOST_ROOT} |
There was a problem hiding this comment.
bootstrap.sh does not accept --without-python; it supports --without-libraries=python instead, and unknown options are treated as fatal. With the current command, Boost configuration exits before b2 runs, so Linux builds fail immediately (and the same unsupported flag is also present in build/iOS/CMakeLists.txt).
Useful? React with 👍 / 👎.
build/CommonCompilerOptions.CMake
Outdated
| CMAKE_CACHE_ARGS | ||
| ${_CMAKE_COMMON_CACHE_ARGS} |
There was a problem hiding this comment.
This ExternalProject_Add(zlib) captures _CMAKE_COMMON_CACHE_ARGS before platform files append target-specific values (for example Android adds ANDROID_ABI/NDK settings only after including CommonCompilerOptions.cmake). As a result, zlib can be configured with host/default settings instead of the target toolchain, which leads to wrong-arch artifacts and downstream link failures when Boost/libssh2 depend on zlib.
Useful? React with 👍 / 👎.
…we need an exception. Protobuf plugin was using config required, which doesn't work on cross compilation scenarios
3 participants
This adds the ability for Boost and others to use our zlib and others to use it with find_package. Seems they were all getting it from the system.